Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place search subnav example on new line #1155

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Place search subnav example on new line #1155

merged 2 commits into from
Sep 8, 2020

Conversation

ashygee
Copy link
Contributor

@ashygee ashygee commented Sep 2, 2020

Fixes break in search subnav component within docs.

  • Fixes:
Current Fix
image image

/cc @primer/ds-core

@ashygee ashygee requested a review from simurai September 2, 2020 17:56
@vercel
Copy link

vercel bot commented Sep 2, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/3pzkjcfy0
✅ Preview: https://primer-css-git-subnav-doc-patch.primer.vercel.app

simurai
simurai approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the intention is to use subnav-search-context next to subnav-links. But maybe fine to fix it here in the docs until we support a responsive version. 👍

docs/content/components/navigation.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview September 3, 2020 04:41 Inactive
@simurai simurai changed the base branch from master to release-15.2.0 September 8, 2020 04:23
@simurai simurai merged commit 0f21d23 into release-15.2.0 Sep 8, 2020
@simurai simurai deleted the subnav-doc-patch branch September 8, 2020 04:23
@simurai simurai mentioned this pull request Sep 10, 2020
Merged
8 tasks
This was referenced Dec 17, 2022
Open
Open
@github-actions github-actions bot mentioned this pull request Dec 25, 2022
Open
@github-actions github-actions bot mentioned this pull request Jan 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

Assignees
No one assigned
Labels
patch release Tag: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashygee @simurai